content.javascript.clipboard seems to cause issues with qt?

[crides]

This may just be me (cuz I have a custom patched qute), but when I merged with v2.5.x I get problems with the content.javascript.clipboard option.

This is the trace that I get:

Traceback (most recent call last):
  File "/home/steven/gitproj/qutebrowser/qutebrowser.py", line 29, in <module>
    sys.exit(qutebrowser.qutebrowser.main())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/steven/gitproj/qutebrowser/qutebrowser/qutebrowser.py", line 245, in main
    return app.run(args)
           ^^^^^^^^^^^^^
  File "/home/steven/gitproj/qutebrowser/qutebrowser/app.py", line 122, in run
    init(args=args)
  File "/home/steven/gitproj/qutebrowser/qutebrowser/app.py", line 157, in init
    _init_modules(args=args)
  File "/home/steven/gitproj/qutebrowser/qutebrowser/app.py", line 496, in _init_modules
    websettings.init(args)
  File "/home/steven/gitproj/qutebrowser/qutebrowser/config/websettings.py", line 247, in init
    webenginesettings.init()
  File "/home/steven/gitproj/qutebrowser/qutebrowser/browser/webengine/webenginesettings.py", line 520, in init
    _init_default_profile()
  File "/home/steven/gitproj/qutebrowser/qutebrowser/browser/webengine/webenginesettings.py", line 399, in _init_default_profile
    _init_profile(default_profile)
  File "/home/steven/gitproj/qutebrowser/qutebrowser/browser/webengine/webenginesettings.py", line 373, in _init_profile
    _global_settings.init_settings()
  File "/home/steven/gitproj/qutebrowser/qutebrowser/browser/webengine/webenginesettings.py", line 226, in init_settings
    super().init_settings()
  File "/home/steven/gitproj/qutebrowser/qutebrowser/config/websettings.py", line 206, in init_settings
    self.update_setting(setting)
  File "/home/steven/gitproj/qutebrowser/qutebrowser/config/websettings.py", line 190, in update_setting
    self._update_setting(setting, value)
  File "/home/steven/gitproj/qutebrowser/qutebrowser/browser/webengine/webenginesettings.py", line 223, in _update_setting
    return super()._update_setting(setting, value)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/steven/gitproj/qutebrowser/qutebrowser/config/websettings.py", line 176, in _update_setting
    self.set_attribute(setting, value)
  File "/home/steven/gitproj/qutebrowser/qutebrowser/config/websettings.py", line 122, in set_attribute
    self._settings.setAttribute(attribute, info.converter(value))
  File "/home/steven/gitproj/qutebrowser/qutebrowser/browser/webengine/webenginesettings.py", line 74, in setAttribute
    settings.setAttribute(attribute, on)
TypeError: setAttribute(self, attr: QWebEngineSettings.WebAttribute, on: bool): argument 2 has unexpected type 'str'

qute seems to work fine if I just filter out anything that has a non-bool as value (which seems like it's always the content.javascript.clipboard option, and the on argument is just access). Clipboards seem to work fine, but I'm not sure if this could be an indication that something else broke.

[The-Compiler]

This is indeed an issue with your fork. See 4a6df3a - I'm guessing there is a wrong merge in qutebrowser/browser/webengine/webenginesettings.py somewhere.

As an aside, I'd prefer if you didn't send crash reports unless you can reproduce issues with an unaltered qutebrowser. They land up in my inbox and I actually look at them, and I'd rather not spend time on investigating issues that are not actually there.

[crides]

Thank you. I don't send reports most of the time, but sometimes I might misclick. Sorry for the troubles that brought you. Is there an option to turn it off by default? I only see that I could close it with escape, which I'll use now. on 26, 2023 09:03, Florian Bruhin ***@***.***> wrote: This is indeed an issue with your fork. See 4a6df3a - I'm guessing there is a wrong merge in qutebrowser/browser/webengine/webenginesettings.py somewhere. As an aside, I'd prefer if you didn't send crash reports unless you can reproduce issues with an unaltered qutebrowser. They land up in my inbox and I actually look at them, and I'd rather not spend time on investigating issues that are not actually there. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[The-Compiler]

Thank you. I don't send reports most of the time, but sometimes I might misclick. Sorry for the troubles that brought you. Is there an option to turn it off by default? I only see that I could close it with escape, which I'll use now.

No worries, it's not a giant issue - just wanted to make sure you're aware.

Indeed pressing Esc does not send the report. What do you mean with "turn it off by default"? Not display the dialog at all? Not sending it when pressing enter? Something else?

[crides]

Oh, I meant not showing the dialog at all

[The-Compiler]

I'd rather not do that, because that gives you zero information about what crash happened and why (unless you happened to run qutebrowser in a terminal).