Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Qt 5.15 on AppVeyor #5237

Closed
The-Compiler opened this issue Feb 14, 2020 · 15 comments
Closed

Issues with Qt 5.15 on AppVeyor #5237

The-Compiler opened this issue Feb 14, 2020 · 15 comments
Labels
component: infrastructure Issues related to development scripts, CI, servers, etc. component: tests Issues related to the testsuite. os: Windows Issues which only happen on Windows. qt: 5.15 Issues related to Qt 5.15.
Projects

Comments

@The-Compiler
Copy link
Member

The-Compiler commented Feb 14, 2020

Now that Qt 5.15 Alpha is out, it's time to check what breaks with it.

Here are Linux wheels for the various alphas/betas: https://qutebrowser.org/tmp/wheels

@The-Compiler The-Compiler added priority: 0 - high Issues which are currently the primary focus. qt: 5.15 Issues related to Qt 5.15. labels Feb 14, 2020
@The-Compiler

This comment has been minimized.

@The-Compiler

This comment has been minimized.

The-Compiler added a commit that referenced this issue Feb 20, 2020
@The-Compiler

This comment has been minimized.

@The-Compiler

This comment has been minimized.

@The-Compiler

This comment has been minimized.

@The-Compiler
Copy link
Member Author

The-Compiler commented Apr 15, 2020

❌ Issues on Windows

FAILED tests/end2end/features/test_downloads_bdd.py::test_aborting_a_download_in_a_different_window_issue_3378 - end2end.fixtures.testprocess.WaitForTimeout: Timed out after 5000ms waiting for {'category': 'ipc', 'module': 'ipc', 'function': 'on_ready_read', 'message': 'Read from socket *'}.
FAILED tests/unit/javascript/stylesheet/test_stylesheet_js.py::test_set_delayed[stylesheet/simple.html] - pytestqt.exceptions.TimeoutError: Signal load_finished(bool) not emitted after 2000 ms
FAILED tests/unit/javascript/stylesheet/test_stylesheet_js.py::test_set_delayed[stylesheet/simple_bg_set_red.html] - pytestqt.exceptions.TimeoutError: Signal load_finished(bool) not emitted after 2000 ms
FAILED tests/unit/javascript/stylesheet/test_stylesheet_js.py::test_set_clear_bg[stylesheet/simple.html] - pytestqt.exceptions.TimeoutError: Signal load_finished(bool) not emitted after 2000 ms
FAILED tests/unit/javascript/stylesheet/test_stylesheet_js.py::test_set_clear_bg[stylesheet/simple_bg_set_red.html] - pytestqt.exceptions.TimeoutError: Signal load_finished(bool) not emitted after 2000 ms
FAILED tests/unit/javascript/stylesheet/test_stylesheet_js.py::test_set_xml - pytestqt.exceptions.TimeoutError: Signal load_finished(bool) not emitted after 2000 ms
FAILED tests/unit/javascript/stylesheet/test_stylesheet_js.py::test_set_svg - pytestqt.exceptions.TimeoutError: Signal load_finished(bool) not emitted after 2000 ms
FAILED tests/unit/javascript/stylesheet/test_stylesheet_js.py::test_appendchild - pytestqt.exceptions.TimeoutError: Signal load_finished(bool) not emitted after 2000 ms
FAILED tests/unit/javascript/test_greasemonkey.py::TestWindowIsolation::test_webengine - pytestqt.exceptions.TimeoutError: Callback wasn't called after 1000ms.
FAILED tests/unit/javascript/test_greasemonkey.py::TestSharedWindowProxy::test_webengine - pytestqt.exceptions.TimeoutError: Callback wasn't called after 1000ms.
FAILED tests/unit/javascript/test_js_execution.py::test_simple_js_webengine[True-0-2.0] - pytestqt.exceptions.TimeoutError: Callback wasn't called after 1000ms.
FAILED tests/unit/javascript/test_js_execution.py::test_simple_js_webengine[False-0-None] - pytestqt.exceptions.TimeoutError: Callback wasn't called after 1000ms.
FAILED tests/unit/javascript/test_js_execution.py::test_simple_js_webengine[True-1-2.0] - pytestqt.exceptions.TimeoutError: Callback wasn't called after 1000ms.
FAILED tests/unit/javascript/test_js_execution.py::test_simple_js_webengine[False-1-2.0] - pytestqt.exceptions.TimeoutError: Callback wasn't called after 1000ms.
FAILED tests/unit/javascript/test_js_execution.py::test_simple_js_webengine[True-2-2.0] - pytestqt.exceptions.TimeoutError: Callback wasn't called after 1000ms.
FAILED tests/unit/javascript/test_js_execution.py::test_simple_js_webengine[False-2-2.0] - pytestqt.exceptions.TimeoutError: Callback wasn't called after 1000ms.
ERROR tests/unit/browser/test_caret.py::test_drop_selection[webengine] - pytestqt.exceptions.TimeoutError: Signal load_finished(bool) not emitted after 1000 ms

haven't investigated yet, but especially the JS tests failing sure is weird...

The loading/JS ones look very similar to #5013 (comment) - maybe it's just the self-built wheel being broken somehow?

Still happens with the RC... However, it does not happen on AppVeyor!

@The-Compiler

This comment has been minimized.

@The-Compiler The-Compiler added this to Focus in Roadmap Apr 29, 2020
@The-Compiler

This comment has been minimized.

@The-Compiler
Copy link
Member Author

The-Compiler commented May 7, 2020

❌ IndexError in test_savingloading_a_session_with_pinned_tabs

https://travis-ci.org/github/qutebrowser/qutebrowser/jobs/684402171

(seems to be flaky)

@The-Compiler
Copy link
Member Author

The-Compiler commented May 7, 2020

✔️ Abort on Travis

https://travis-ci.org/github/qutebrowser/qutebrowser/jobs/684402172

Fixed by adding some more packages on Travis:

  • libxcb-icccm4
  • libxcb-image0
  • libxcb-keysyms1
  • libxcb-randr0
  • libxcb-render-util0
  • libxcb-xinerama0

@The-Compiler
Copy link
Member Author

Looks quite good with the RC so far - no issues on Linux/macOS/Windows with Travis/AppVeyor from what it looks like.

@The-Compiler
Copy link
Member Author

The-Compiler commented May 11, 2020

❌ Failing session comparison in test_saving_session_with_onlyactivewindow

https://travis-ci.org/github/qutebrowser/qutebrowser/jobs/685390077

(seems to be flaky)

Not entirely sure what happens there - it looks like 4.txt isn't loaded fully when the session is saved, but the lines above should already wait for that to happen in the test. On the newest master, I removed suppressing log output on CI, so hopefully we'll soon have an idea what's going on there.

@The-Compiler
Copy link
Member Author

The-Compiler commented Jun 1, 2020

❌ Failing tests on AppVeyor

https://ci.appveyor.com/project/qutebrowser/qutebrowser/builds/33239304/job/8objoatr2xwj6qqs
full log: https://ci.appveyor.com/api/buildjobs/8objoatr2xwj6qqs/log

Seems to fail with:

[2968:3108:0601/123442.125:ERROR:mf_helpers.cc(14)] Error in dxva_video_decode_accelerator_win.cc on line 517

Maybe that can just be ignored?

Some more remaining after the ignore:

https://ci.appveyor.com/project/qutebrowser/qutebrowser/builds/33240282/job/nd07jkx5676k8ppw

The-Compiler added a commit that referenced this issue Jun 1, 2020
The-Compiler added a commit that referenced this issue Jun 1, 2020
@The-Compiler The-Compiler changed the title Issues with Qt 5.15 Issues with Qt 5.15 on AppVeyor Jun 18, 2020
@The-Compiler The-Compiler added component: infrastructure Issues related to development scripts, CI, servers, etc. component: tests Issues related to the testsuite. os: Windows Issues which only happen on Windows. and removed priority: 0 - high Issues which are currently the primary focus. labels Jun 18, 2020
@The-Compiler The-Compiler moved this from Focus to Backlog in Roadmap Jun 18, 2020
@The-Compiler
Copy link
Member Author

The-Compiler commented Jun 18, 2020

Only the AppVeyor issue is remaining, everything else should hopefully be okay now.

@The-Compiler
Copy link
Member Author

Roadmap automation moved this from Backlog to Done Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: infrastructure Issues related to development scripts, CI, servers, etc. component: tests Issues related to the testsuite. os: Windows Issues which only happen on Windows. qt: 5.15 Issues related to Qt 5.15.
Projects
Roadmap
  
Done
Development

No branches or pull requests

1 participant