Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font family quoting in the config #5576

Open
The-Compiler opened this issue Jul 7, 2020 · 0 comments
Open

Font family quoting in the config #5576

The-Compiler opened this issue Jul 7, 2020 · 0 comments
Labels
bug: behavior Something doesn't work as intended, but doesn't crash. component: config Issues related to configuration. priority: 2 - low Issues which are currently not very important.

Comments

@The-Compiler
Copy link
Member

making a note for future searchers here -- one quirk of the Font type is you need to escape spaces in your font family name now

Originally posted by @neeasade in #5512 (comment)

The current situation is a bit confusing:

  • Some settings changed types (notably fonts.tabs -> fonts.tabs.selected / .unselected and fonts.debug_console)
  • However, there was a subtle behavior change there which isn't handled by the migrations: The Font config type requires quoting for font families containing spaces, which QtFont did not.

Not sure what to do about it... I suppose we could fix the migrations, but that would make the migration rather complex (needing to parse the value) and won't help people who already are running the newer version (unless we detect this case of an unquoted font name with spaces and fix it in another migration).

Alternatively, I suppose we could make the quoting optional for Font, relying on our own parsing.

I suppose the easiest option would be to not do anything about it 😆

@The-Compiler The-Compiler added bug: behavior Something doesn't work as intended, but doesn't crash. component: config Issues related to configuration. priority: 2 - low Issues which are currently not very important. labels Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behavior Something doesn't work as intended, but doesn't crash. component: config Issues related to configuration. priority: 2 - low Issues which are currently not very important.
Projects
None yet
Development

No branches or pull requests

1 participant