Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

javascript.string_replace fails in some corner cases with QtWebEngine #5666

Open
The-Compiler opened this issue Aug 11, 2020 · 0 comments
Open

javascript.string_replace fails in some corner cases with QtWebEngine #5666

The-Compiler opened this issue Aug 11, 2020 · 0 comments
Labels
bug: behavior Something doesn't work as intended, but doesn't crash. component: QtWebEngine Issues related to the QtWebEngine backend, based on Chromium. language: javascript Issues which require knowing JavaScript. priority: 2 - low Issues which are currently not very important.

Comments

@The-Compiler
Copy link
Member

  • \x00 seems to end strings (even if escaped?) so \x00 turns into '' and '𐀀\x00𐀀\x00' turns into '𐀀'
  • '\ufeff' turns into ''
@The-Compiler The-Compiler added priority: 2 - low Issues which are currently not very important. component: QtWebEngine Issues related to the QtWebEngine backend, based on Chromium. language: javascript Issues which require knowing JavaScript. bug: behavior Something doesn't work as intended, but doesn't crash. labels Aug 11, 2020
The-Compiler added a commit that referenced this issue Aug 11, 2020
@The-Compiler
Make javascript.string_escape tests run with QtWebEngine
e652dcc 
Reveals some issues, see #5666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: behavior Something doesn't work as intended, but doesn't crash. component: QtWebEngine Issues related to the QtWebEngine backend, based on Chromium. language: javascript Issues which require knowing JavaScript. priority: 2 - low Issues which are currently not very important.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@The-Compiler