Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-release: Update creating symlinks for Qt 6 #7252

Open
The-Compiler opened this issue Jun 15, 2022 · 4 comments
Open

build-release: Update creating symlinks for Qt 6 #7252

The-Compiler opened this issue Jun 15, 2022 · 4 comments
Labels
component: infrastructure Issues related to development scripts, CI, servers, etc. os: macOS Issues which only happen on macOS. priority: 2 - low Issues which are currently not very important. qt: 6 Issues related to Qt 6.

Comments

@The-Compiler
Copy link
Member

Might be needed for #6771.

# Replace some duplicate files by symlinks
framework_path = os.path.join(app_path, 'Contents', 'MacOS', 'PyQt5',
'Qt5', 'lib', 'QtWebEngineCore.framework')
core_lib = os.path.join(framework_path, 'Versions', '5', 'QtWebEngineCore')
os.remove(core_lib)
core_target = os.path.join(*[os.pardir] * 7, 'MacOS', 'QtWebEngineCore')
os.symlink(core_target, core_lib)
framework_resource_path = os.path.join(framework_path, 'Resources')
for name in os.listdir(framework_resource_path):
file_path = os.path.join(framework_resource_path, name)
target = os.path.join(*[os.pardir] * 5, name)
if os.path.isdir(file_path):
shutil.rmtree(file_path)
else:
os.remove(file_path)
os.symlink(target, file_path)

Seems to be broken with Qt 6 as well.

@The-Compiler The-Compiler added component: infrastructure Issues related to development scripts, CI, servers, etc. priority: 0 - high Issues which are currently the primary focus. os: macOS Issues which only happen on macOS. labels Jun 15, 2022
@The-Compiler
Copy link
Member Author

The-Compiler commented Jun 16, 2022

@The-Compiler The-Compiler changed the title build-release: Upstream creating symlinks instead of copies build-release: Update creating symlinks for Qt 6 Jun 17, 2022
@The-Compiler The-Compiler added the qt: 6 Issues related to Qt 6. label Jun 17, 2022
@The-Compiler
Copy link
Member Author

Hmm, the symlinks appear to be correct. However, the macOS Sandbox does not seem to permit accessing the symlinked files, I think?

Jun 20 09:34:41  QtWebEngineProcess[76156] <Error>: SeatbeltExecServer: Failed to initialize sandbox: -1 empty subpath pattern

@The-Compiler The-Compiler added priority: 2 - low Issues which are currently not very important. and removed priority: 0 - high Issues which are currently the primary focus. labels Jun 20, 2022
@The-Compiler
Copy link
Member Author

Oh, looks like that was a red herring, see #7278.

@The-Compiler
Copy link
Member Author

Actual output:

Qt WebEngine resources not found at . Trying parent directory...
Qt WebEngine resources not found at /Users/florian/proj/qutebrowser/git/dist/qutebrowser.app/Contents/Resources/PyQt6/Qt6. Trying application directory...
Qt WebEngine resources not found at . Trying fallback directory... The application MAY NOT work.
Installed Qt WebEngine locales directory not found at location /qtwebengine_locales. Trying application directory...
Qt WebEngine locales directory not found at location /qtwebengine_locales. Trying fallback directory... Translations MAY NOT not be correct.
[0621/162511.848905:ERROR:icu_util.cc(253)] Couldn't mmap icu data file
Qt WebEngine resources not found at . Trying parent directory...
Qt WebEngine resources not found at /Users/florian/proj/qutebrowser/git/dist/qutebrowser.app/Contents/Resources/PyQt6/Qt6. Trying application directory...
Qt WebEngine resources not found at . Trying fallback directory... The application MAY NOT work.
Installed Qt WebEngine locales directory not found at location /qtwebengine_locales. Trying application directory...
Qt WebEngine locales directory not found at location /qtwebengine_locales. Trying fallback directory... Translations MAY NOT not be correct.
[0621/162512.172099:ERROR:icu_util.cc(253)] Couldn't mmap icu data file
Qt WebEngine resources not found at . Trying parent directory...
Qt WebEngine resources not found at /Users/florian/proj/qutebrowser/git/dist/qutebrowser.app/Contents/Resources/PyQt6/Qt6. Trying application directory...
Qt WebEngine resources not found at . Trying fallback directory... The application MAY NOT work.
Installed Qt WebEngine locales directory not found at location /qtwebengine_locales. Trying application directory...
Qt WebEngine locales directory not found at location /qtwebengine_locales. Trying fallback directory... Translations MAY NOT not be correct.
[0621/162512.957667:ERROR:icu_util.cc(253)] Couldn't mmap icu data file
Qt WebEngine resources not found at . Trying parent directory...
Qt WebEngine resources not found at /Users/florian/proj/qutebrowser/git/dist/qutebrowser.app/Contents/Resources/PyQt6/Qt6. Trying application directory...
Qt WebEngine resources not found at . Trying fallback directory... The application MAY NOT work.
Installed Qt WebEngine locales directory not found at location /qtwebengine_locales. Trying application directory...
Qt WebEngine locales directory not found at location /qtwebengine_locales. Trying fallback directory... Translations MAY NOT not be correct.
[0621/162513.000637:ERROR:icu_util.cc(253)] Couldn't mmap icu data file

File sizes:

  • Full symlinking: 383 MB
  • Partial symlinking (still seems to work fine?): 548 MB
  • No symlinking: 590 MB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: infrastructure Issues related to development scripts, CI, servers, etc. os: macOS Issues which only happen on macOS. priority: 2 - low Issues which are currently not very important. qt: 6 Issues related to Qt 6.
Projects
None yet
Development

No branches or pull requests

1 participant