Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eslint 9+ in CI #8159

Open
toofar opened this issue Apr 6, 2024 · 0 comments
Open

Support eslint 9+ in CI #8159

toofar opened this issue Apr 6, 2024 · 0 comments

Comments

@toofar
Copy link
Member

toofar commented Apr 6, 2024

Seems that a new major version of eslint has landed in the docker container we use for CI. eslint is just used to lint some small JS files, so it isn't a critical component, but it's making all CI runs report as failed atm, so I'll pin it to <9.0.0

This issue is for unpinning eslint again which looks like it'll require migrating our config file to the new format (and not much else), I've made a start on that here: https://github.com/qutebrowser/qutebrowser/tree/feat/eslint9

The migrating guide is here: https://eslint.org/docs/latest/use/migrate-to-9.0.0

Here's an example of a failing CI run: https://github.com/qutebrowser/qutebrowser/actions/runs/8576697138/job/23508116987

image

toofar added a commit that referenced this issue Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant