Fix completion sorting #3237
Merged
Fix completion sorting #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I previously removed the sorting logic from SortFilter thinking it was unnecessary if we construct the model with a sorted list. However, this only worked when no pattern was set, and the items are misordered as soon as a pattern is input. This patch reintroduces alpha-sorting, which can be disabled by passing sort=False to the ListCategory constructor. The session completion test had to be tweaked as it simulated the incorrect assumption that the session list is not alpha-ordered; sessions come out of the session-manager pre-sorted so we may as well use alpha-sorting in the session completion model. Resolves qutebrowser#3156.
We really just need to check that the row exists here, the date doesn't matter. Checking the date here is actually flaky with regards to time. When running locally at 11:50 EST, it failed with: ``` assert self._model.data(self._model.index(row, col)) == item AssertionError: assert '1969-12-31' == '1970-01-01' - 1969-12-31 + 1970-01-01 ``` It was wrong to assume that an atime of 0 would always format to 1970-01-01.
|
Welp, I broke something in master yesterday evening 😉 |
The-Compiler
approved these changes
Nov 3, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's also a fix for a histcategory test that was failing locally while working on this -- turns out it was timezone sensitive 😬
This change is