Make Config.dump_userconfig return the same as config-write-py #4398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qutebrowser-bot
added
status: needs review
easy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4229
I had to move
configfiles.ConfigPyWriterto avoid a circular import, and I renamed it since it's no longer in charge of writing a file but more of generating a string. I also replaced itswritemethod withgen_lines.There are a bunch of broken tests but I want you opinion on the aproach I took before fixing them.
PS: sorry about the overflow of pull requests, this is totally not related to these being the last days of Hacktoberfest 😄. Don't worry though, I'll write tests for all of them and update them as needed. I still have one more to go but I think I'll choose another project before you ban me for life 😂.
This change is