Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KDE Platform to known distributions #4865

Merged
merged 1 commit into from Jun 30, 2019

Conversation

ykgmfq
Copy link
Contributor

@ykgmfq ykgmfq commented Jun 24, 2019

The platform does not specify a pretty name yet, so that remains Unknown for now. I will see if I can get a pretty name into upstream.

The platform does not specify a pretty name yet,
so that remains *Unknown* for now.
@The-Compiler
Copy link
Member

I'm a bit surprised that this works, with the dots in the enum name - does it?

@ykgmfq
Copy link
Contributor Author

ykgmfq commented Jun 24, 2019

e=Enum('test',['a','b.c']) 
e.a                                                                                  
<test.a: 1>

e.b.c
AttributeError: b

e['b.c']                                                                             
<test.b.c: 2>

It apparently does work dependent on how you access it. The code in version.py works anyways...

@ykgmfq
Copy link
Contributor Author

ykgmfq commented Jun 24, 2019

I could alternatively use id_mappings to get rid of the dots.

@The-Compiler The-Compiler merged commit d78fd85 into qutebrowser:master Jun 30, 2019
@The-Compiler
Copy link
Member

Thanks! I ended up doing that (and adding a test) in b43e54d.

@ykgmfq
Copy link
Contributor Author

ykgmfq commented Jul 1, 2019

Upstream change for the pretty name: https://invent.kde.org/kde/flatpak-kde-runtime/merge_requests/1

@The-Compiler
Copy link
Member

Good idea! I also added a proper fallback on NAME if PRETTY_NAME isn't set: 88f5433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants