New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed default search engines. Closes #533. #542
Conversation
Not sure what to think about this. It should be possible to remove those search engines by setting it to an empty value, though that seems to be broken... Whoops! 😊 But I'd still like to ship a minimal useful set of default search engines, especially I suggest keeping them for now, and fixing this properly with the big config revolution at #499. Other opinions? /cc @oed I'll take a look at why |
I agree, it's not that important right now. No real reason to do anything before the switch to yaml. |
It doesnt work because {} is expected in the searchengine string. And if i set google = {}, searching for 'google sucks' tries to open http://sucks :/ |
Well I think that having the DEFAULT should actually be sufficient.
Patric Schmitz bzk0711@aol.com |
I've kept duckduckgo as the DEFAULT search engine. Thats enough I think. Custom search strings should be the choice of the user imo. |
QUrl parses
I still think qutebrowser should offer some sensible defaults for configs, like e.g. for the ad block lists as well. As said, currently you should be able to remove entries by setting them to an empty URL (will look at why this is broken this evening), and with #499 I've to think about how to handle default values in general. But this is just a quick workaround for a debatable topic, so I'm closing this - sorry! |
Closes qutebrowser#544. We might also merge qutebrowser#542 now.
After talking with @flvi0 a bit I got conviced this actually might be a good idea indeed. I'll reopen and merge. Sorry for the hassle! |
yay, thanks! :) |
This change is