Histcomplete some fixes for #547 #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two things here. One is to use `WebHistory._new_history` only as a to-save queue, so we now add entries to `_old_urls` when they are first created and can now no longer iterate of `_new_history` in `__iter__()`. Second is to stop blindly tacking new history entries on the end of the history completion model. It does involve iterating over the model to find the existing entry but we only do that if we know the duplicate is there, which is fast to check. This also ads another point of mutation to the history completion model which may prove problematic if it leads to more segfaults.
| @@ -99,8 +99,7 @@ def __getitem__(self, key): | |||
| return self._new_history[key] | |||
|
|
|||
| def __iter__(self): | |||
| return itertools.chain(self._old_urls.values(), | |||
| iter(self._new_history)) | |||
| return self._old_urls.values().__iter__() | |||
There was a problem hiding this comment.
Please do iter(self._old_urls.values()) instead - I think it does the same in this case, but it's usually discouraged to call magic methods directly.
|
Some more small remarks:
|
The-Compiler
added a commit
that referenced
this pull request
Mar 12, 2015
The need for those were removed in #548.
The-Compiler
added
the
component: completion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a couple of commits for the histcomplete branch. I cleaned up that confusing comment (which is there in case anyone goes looking for history stats like number if hits for some reason and wonders why we are throwing that info away, for now). And added some code to remove duplicates, both when iterating
WebHistoryand in the completion model.This change is