Retain sort order for undo completion model #5964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because 10 shouldn't be higher than 2.
toofar
force-pushed
the
fix/dont_sort_undo_completion
branch
from
b19b7df
to
f0ed206
Compare
toofar
added a commit
that referenced
this pull request
Mar 10, 2024
I've made TreeUndoEntry a subclass of UndoEntry. But UndoEntry sets a default value for the `created_at` attribute, which means if any of the extra attributes defined on the child class don't define a default an error is thrown complaining about non-keyword arguments after a keyword only one. Python 3.10 adds a kw_only argument you can pass to the dataclass decorator but it looks like we currently support python 3.8+. See https://www.trueblade.com/blogs/news/python-3-10-new-dataclass-features So a more compatible way to do it is to set `init=False` on the attribute with a default, if you don't need to pass it in the constructor. Which we don't because it's only set by the caller in tests. Hence changing the tests to set it a different way. A bit uglier but should be fine. Also fix my "retains_sort_order" test from #5964 that wasn't actually being run...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because 10 shouldn't be higher than 2.