Add completion.item_padding

[kyza0d]

No description provided.

[The-Compiler]

This just crashes qutebrowser outright. Please make sure you actually try your code and can confirm it works.

[segf00lt]

For controling the padding values it might be better to use separate options instead of a Dict.

completion.item_padding.top:
  default: 1
  type:
    name: Int
    minval: 0
  desc: Top padding (in pixels) of items in the completion window.

completion.item_padding.bottom:
  default: 1
  type:
    name: Int
    minval: 0
  desc: Bottom padding (in pixels) of items in the completion window.

completion.item_padding.left:
  default: 0
  type:
    name: Int
    minval: 0
  desc: Left padding (in pixels) of items in the completion window.

completion.item_padding.right:
  default: 0
  type:
    name: Int
    minval: 0
  desc: Right padding (in pixels) of items in the completion window.

And the changes for the stylesheet in completionwidget.py:

        QTreeView:item {
            padding-top: {{ conf.completion.item_padding.top }}px;
            padding-bottom: {{ conf.completion.item_padding.bottom }}px;
            padding-left: {{ conf.completion.item_padding.left }}px;
            padding-right: {{ conf.completion.item_padding.right }}px;
        }

[The-Compiler]

Why? We already have a Padding type we use elsewhere, so it seems to make sense to use it here too, no?

[segf00lt]

Yeah that makes more sense. I was thinking it would be a setting the user would occasionally change at runtime, but just as a setting in the config file it does make more sense to use Padding.

[vereis]

This looks like it hasn't had any updates in awhile, @The-Compiler would you be open to another shot at implementing this feature?

I'm not sure what the process typically is when it comes to these PRs which have been sitting around for awhile?

[The-Compiler]

@vereis Sorry for the delay, I was taking a bit of a break from qutebrowser stuff. I think this one should actually be okay from a quick look, unless you see something that would be missing here.

Usually with older PRs it's really appreciated if someone helps picking things up and getting them updated, but here I think there is nothing left to do, except on my end of things. I'm currently focusing on Qt 6 stuff, but then want to go back and hopefully merge a big batch of PRs again after that.

[mschilli87]

configdata.yml changes LGTM as well.

[vereis]

No worries at all! I really appreciate it; I've only started using qutebrowser recently but I'm really loving it so far!

Really appreciate you following up again ❤️ Looking forward to everything else you have in store!

[arza-zara]

I somewhat prefer the old default of 0 for all

[mschilli87]

@The-Compiler: Just making sure this doesn't slip through your attention due to @kyza0dev removing their fork.