Update dependencies #8179
Merged
Update dependencies #8179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With pytest 8.2, pytest.importorskip(...) now only considers ModuleNotFoundError rather than all ImportErrors, and warns otherwise: pytest-dev/pytest#12220 While we could override this via pytest.importorskip(..., exc_type=machinery.Unavailable) this is a simpler solution, and it also makes more sense semantically: We only raise Unavailable when an import is being done that would otherwise result in a ModuleNotFoundError anyways (e.g. trying to import QtWebKit on Qt 6).
|
The arguably only relevant upgrade here is pytest 8.2, and that actually broke our tests due to a change reviewed by yours truly 馃槅 Fixed here: 3d96fc2 |
Similarly to 24d01ad, failing Qt 5.15 tests showed some evidence of us being stuck in command mode in the next test file (hints.feature). On the first test there ("Scenario: Using :hint-follow outside of hint mode (issue 1105)"): 17:38:51.073 ERROR message message:error:63 hint-follow: This command is only allowed in hint mode, not command. but: end2end.fixtures.testprocess.WaitForTimeout: Timed out after 15000ms waiting for {'category': 'message', 'loglevel': 40, 'message': 'hint-follow: This command is only allowed in hint mode, not normal.'}. I agree with what has been said: This should never happen, because we restart the qutebrowser process between test files. I did some of the mentioned "more examination" but also don't have an explanation. To avoid more flaky tests, let's roll with another bandaid solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed files
Version updates
I'm a bot, bleep, bloop. 馃