Spike: refactor disable/enable logic for statusbar widgets via composition #8240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylbrecht
force-pushed
the
statusbar-composition-spike
branch
3 times, most recently
from
c761737
to
47aa461
Compare
# DISCLAIMER Super duper WIP changes ahead. --- I just want to see what problems arise when using composition over inheritance, as suggested by @The-Compiler in qutebrowser#7407 (comment). There is a lot of unaddressed ugliness (e.g. `widget.widget` everywhere) in this commit. I just started with moving `QLabel` into `TextBase.widget`. Then fixing failing tests one by one with the *easiest* solution (e.g. `widget.widget`); I even marked one test with `xfail` because I could not quickly figure out why it was failing. My hope is to get a better feel for what belongs to `QWidget` and what belongs to `TextBase` (or its subclasses).
pylbrecht
force-pushed
the
statusbar-composition-spike
branch
from
47aa461
to
78c451b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISCLAIMER
Super duper WIP changes ahead.
I just want to see what problems arise when using composition over inheritance, as suggested by @The-Compiler in
#7407 (comment).
There is a lot of unaddressed ugliness (e.g.
widget.widgeteverywhere) in this commit. I just started with movingQLabelintoTextBase.widget. Then fixing failing tests one by one with the easiest solution (e.g.widget.widget); I even marked one test withxfailbecause I could not quickly figure out why it was failing.My hope is to get a better feel for what belongs to
QWidgetand what belongs toTextBase(or its subclasses).Relates to #7407