Hotfix/small improvements #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 145
💛 - Coveralls |
Using np.expm1 = np.exp - 1 is not only faster than calling cexp - 1 but also more precise for small arguments, thus alleviating the need for masking small values and manually setting the small-arg limit. We can also precompute i*EdE by manually assigning the imaginary part of a pre-allocated array using the out kwarg since we need it both in the exponent and the denominator of the integral.
Can assign real and imaginary parts directly using the out kwarg of np.cos and np.sin without using an intermediate buffer array.
Makes tests more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of small improvements.