Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/make plotting optional dependency #29

Merged
merged 36 commits into from
Jul 6, 2020

Conversation

thangleiter
Copy link
Member

Implement #25 and moreoever make the plotting.py module an optional extra.

@coveralls
Copy link

coveralls commented Jun 25, 2020

Pull Request Test Coverage Report for Build 225

  • 75 of 76 (98.68%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-66.7%) to 28.224%

Changes Missing Coverage Covered Lines Changed/Added Lines %
filter_functions/util.py 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
filter_functions/util.py 3 85.45%
Totals Coverage Status
Change from base Build 209: -66.7%
Covered Lines: 192863
Relevant Lines: 590726

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@0b42bfa). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage          ?   93.72%           
=========================================
  Files             ?        7           
  Lines             ?     1866           
  Branches          ?      450           
=========================================
  Hits              ?     1749           
  Misses            ?       68           
  Partials          ?       49           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b42bfa...45162ed. Read the comment docs.

@thangleiter thangleiter merged commit 21f81f1 into master Jul 6, 2020
@thangleiter thangleiter deleted the refactor/make_plotting_optional_dependency branch July 6, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants