Skip to content

Commit

Permalink
Merge pull request #553 from qutech/fix/as_expression_abstract
Browse files Browse the repository at this point in the history
AtomicPulseTemplate._as_expression is no longer abstract
  • Loading branch information
terrorfisch committed Mar 3, 2021
2 parents 393702a + 81cfd3c commit 35a10a3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion qupulse/pulses/pulse_template.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,10 +349,10 @@ def build_waveform(self,
does not represent a valid waveform of finite length.
"""

@abstractmethod
def _as_expression(self) -> Dict[ChannelID, ExpressionScalar]:
"""Helper function to allow integral calculation in case of truncation. AtomicPulseTemplate._AS_EXPRESSION_TIME
is by convention the time variable."""
raise NotImplementedError(f"_as_expression is not implemented for {type(self)} which means it cannot be truncated and integrated over.")


class DoubleParameterNameException(Exception):
Expand Down

0 comments on commit 35a10a3

Please sign in to comment.