Fixed a subtle potential bug in loop_pulse_template_tests test_build_… #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sequence_constraint_on_loop_var_exception(). A parameter constraint violation was passed only because of the arbitrary order in which the constraints where specified and the fact that one of them was expected to fail with a ParameterNotProvided exception.
lumip
deleted the
fix/test_build_sequence_constraint_on_loop_var_exception
branch
lumip
restored the
fix/test_build_sequence_constraint_on_loop_var_exception
branch
lumip
deleted the
fix/test_build_sequence_constraint_on_loop_var_exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sequence_constraint_on_loop_var_exception().
A parameter constraint violation was passed only because of the arbitrary order in which the constraints where specified and the fact that one of them was expected to fail with a ParameterNotProvided exception.