Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in Tektronix driver #470

Merged
merged 4 commits into from Jun 14, 2019
Merged

Fix bugs in Tektronix driver #470

merged 4 commits into from Jun 14, 2019

Conversation

terrorfisch
Copy link
Member

@terrorfisch terrorfisch commented Jun 13, 2019 •
edited

  • isinstance(entry, int) in line _process_program does now handle arbitrary integer types
  • _get_empty_sequence_positions now returns only as much free positions as asked for (+ tests)

@coveralls
Copy link

coveralls commented Jun 13, 2019 •
edited

Pull Request Test Coverage Report for Build 1818

  • 3 of 15 (20.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 89.896%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qupulse/hardware/awgs/tektronix.py 3 15 20.0%
Totals Coverage Status
Change from base Build 1810: 0.1%
Covered Lines: 5097
Relevant Lines: 5593
💛 - Coveralls

@terrorfisch terrorfisch merged commit 559e6b4 into master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@terrorfisch @coveralls