Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Prevent Earth triangles from showing their borders #232

Merged

Conversation

jonaseberle
Copy link
Member

@jonaseberle jonaseberle commented May 12, 2023

I had these ugly lines on an Nvidia GTX 3060:

image

Digging a bit brought me to a list of common OpenGL mistakes... https://www.khronos.org/opengl/wiki/Common_Mistakes#glEnable.28GL_POLYGON_SMOOTH.29

So..., now GL_POLYGON_SMOOTH is off.

I had that problem on an Nvidia GTX 3060.

Digging a bit brought me to a list of common OpenGL mistakes...
https://www.khronos.org/opengl/wiki/Common_Mistakes#glEnable.28GL_POLYGON_SMOOTH.29

So well, now GL_POLYGON_SMOOTH is off.
@jonaseberle jonaseberle changed the title [BUGFIX] Prevent earth triangles to expose their borders [BUGFIX] Prevent earth triangles from showing their borders May 13, 2023
@jonaseberle jonaseberle changed the title [BUGFIX] Prevent earth triangles from showing their borders [BUGFIX] Prevent Earth triangles from showing their borders May 13, 2023
@jonaseberle
Copy link
Member Author

I'd like to ask our "regulars" if I have broken the display with that change

@FlyingFoxVATSIM @diibify @Luca0208 @droesen

If you have time could you please quickly unzip and start this https://github.com/qutescoop/qutescoop/suites/12866882191/artifacts/693872488 (Windows) and report if that has introduced any new uglyness for you?

@diibify
Copy link
Contributor

diibify commented May 13, 2023

For me everything seems to have remained intact. Thanks for all the effort!

@FlyingFoxVATSIM
Copy link
Contributor

Oh yes, nice! Works for me, too! GTX1060 here.

@jonaseberle
Copy link
Member Author

Great, thanks :)

@jonaseberle jonaseberle merged commit 6319ed9 into qutescoop:master May 13, 2023
5 checks passed
@jonaseberle jonaseberle deleted the fix/remove-gl-polygon-smooth branch May 13, 2023 22:43
@droesen
Copy link

droesen commented May 15, 2023

Late, but: all fine here on GTX1660SUPER

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants