Constructing general spin-j operators #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 92.52% 92.72% +0.19%
==========================================
Files 26 26
Lines 1847 1884 +37
==========================================
+ Hits 1709 1747 +38
+ Misses 138 137 -1 ☔ View full report in Codecov by Sentry. |
ytdHuang
changed the title
| """ | ||
| sigmap() = destroy(2) | ||
| sigmap() = jmat(0.5, Val(:+)) |
There was a problem hiding this comment.
Is it more efficient that the previous definition?
There was a problem hiding this comment.
I think for sigmap and sigmam, are not so different compared to the original methods.
However, I do think sigmax, sigmay, and sigmaz would be slightly efficient.
Also, I personally think it is a bit weird to see sigmap() = destroy(2) lol.
albertomercurio
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for constructing general Spin-
joperators (same function names within Pythonqutip), wherejis the spin quantum numbers that can only be non-negative integer or half-integer.Summary of this PR:
jmatspin_Jxspin_Jyspin_Jzspin_Jmspin_Jpspin_J_setjmat:sigmap() = jmat(0.5, :+)sigmam() = jmat(0.5, :-)sigmax() = 2 * jmat(0.5, :x)sigmay() = 2 * jmat(0.5, :y)sigmaz() = 2 * jmat(0.5, :z)