change groups #22
Merged
change groups #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hodgestar
requested changes
Sep 11, 2022
There was a problem hiding this comment.
I suggested two kinds of changes
One is just naming spacing the group names, so that we can use that to automatically organize the benchmarks a bit if needed, and made the names a bit more readable.
The other is trying to reorganize the solver groups in a way that makes more sense to me.
xspronken
force-pushed
the
groups_update
branch
from
7a629a7
to
e4a1da0
Compare
|
We also should note that because the operation name is retrieved from the group, the benchmarks currently displayed on the website will have to be discarded or modified to fit with the new names. |
hodgestar
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing how the groups are defined.