Fix a bug for the wrong tlist in c_ops #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoxiLi
force-pushed
the
decoherence_noise_bug
branch
from
c8f3383
to
3e8cfc9
Compare
The get_full_tlist method only considers the tlist in the ideal pulse. Use the tlist of the generated QobjEvo, which already includes all the time steps.
BoxiLi
force-pushed
the
decoherence_noise_bug
branch
from
3e8cfc9
to
5974368
Compare
BoxiLi
added a commit
to BoxiLi/qutip-qip
that referenced
this pull request
Nov 24, 2021
The get_full_tlist method only considers the tlist in the ideal pulse. If the Lindblad noise has a different time dependency, this will cause inconsistency. Use the tlist of the generated QobjEvo, which already includes all the time steps.
BoxiLi
added a commit
to BoxiLi/qutip-qip
that referenced
this pull request
Nov 24, 2021
The get_full_tlist method only considers the tlist in the ideal pulse. If the Lindblad noise has a different time dependency, this will cause inconsistency. Use the tlist of the generated QobjEvo, which already includes all the time steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_full_tlistmethod only considers the tlist in the ideal pulse. Use the tlist of the generatedQobjEvo, which already includes all the time steps.