-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/export png with dpi #139
Conversation
Looks good. I'll test it locally later today. The falling linting is just the black python styling. We don't really want to include Instead, you could add a test to |
|
Hi @BoxiLi , I've added the density argument to old converter and added a test that looks for exported png files(with different dpi) and SVG. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
I left some comments to clear the logic in the code. Don't worry about the coverage, the CI has no pdflatex installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally, LGTM!
@srinathkp Congrats! |
Thanks Boxi ! Many more to come hopefully 💥🤞 |
New method QubitCircuit.draw() to export svg and png images. Density in dpi can be an argument from the user for conversion to png (defaults to 100dpi).
For #133 - Allow setting dpi/density when exporting circuits to PNG
New method
QubitCircuit.draw()
to export svg and png images. Density in dpi can be an argument from the user for conversion to png ( defaults to 100dpi).