Fix usage of rand_unitary and rand_ket
#163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian512
changed the title
rand_unitary for QuTiP 5rand_unitary and rand_ket
BoxiLi
pushed a commit
to BoxiLi/qutip-qip
that referenced
this pull request
Oct 23, 2022
* add version test for definition of rand_unitary * fix usage of rand_ket and rand_unitary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of
rand_unitaryhas changed recently in QuTiP 5. The argumentdimsno longer exists. This PR changes the two usages ofrand_unitaryby checking the version of QuTiP and then using the corresponding definition.The same holds for
rand_ket.The tests were recently failing due to this change in QuTiP 5.