Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter the measured probability #182

Merged
merged 6 commits into from
Dec 9, 2022
Merged

Conversation

BoxiLi
Copy link
Member

@BoxiLi BoxiLi commented Dec 8, 2022

Use the atol option in qutip to determine the tolerance for measurement. And filter out the states with a probability smaller than this.

See also: qutip/qutip#2029

Use the atol option in qutip to determine the tolerance for measurement. And filter out the states with a probability smaller than this.
Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have a test for this, but the change looks right.

@BoxiLi
Copy link
Member Author

BoxiLi commented Dec 9, 2022

The changes are moved to the basic measurement class in qutip-qip. It is a lower-level function so we don't need to apply the filtering twice in the code. A test is added.

@BoxiLi BoxiLi added this to the qutip-qip-0.2.3 milestone Dec 9, 2022
@BoxiLi BoxiLi merged commit 85303bb into qutip:master Dec 9, 2022
BoxiLi added a commit to BoxiLi/qutip-qip that referenced this pull request Dec 11, 2022
Use the atol option in qutip to determine the tolerance for measurement. And filter out the states with a probability smaller than this.
BoxiLi added a commit to BoxiLi/qutip-qip that referenced this pull request Dec 11, 2022
Use the atol option in qutip to determine the tolerance for measurement. And filter out the states with a probability smaller than this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants