Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests again the dev.major branch of Qutip. #189

Merged
merged 3 commits into from
Jan 22, 2023

Conversation

Ericgig
Copy link
Member

@Ericgig Ericgig commented Jan 19, 2023

We merged the branch dev.major branch into master last Monday. Thus tests against both of these branches are redundant.
I remove the test using qutip@dev.major since all further work for v5 will be done in master. It was the only test using python 3.10, so updated another test to use it.

There are no longer any active development branch for v4, all test using qutip v4 are ran using released version.

@@ -12,12 +12,6 @@ jobs:
strategy:
matrix:
include:
- case-name: qutip@dev.major
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this case should stay but become qutip@master and then the case below should become qutip@qutip-4-7-X.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will still make fixes to 4.7.X and qutip-qip should still test against it.

@BoxiLi BoxiLi merged commit 204d538 into qutip:master Jan 22, 2023
@Ericgig Ericgig deleted the post.dev.major.merger branch January 22, 2023 19:58
@BoxiLi BoxiLi added the qutip5 qutip 5 compatibility label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qutip5 qutip 5 compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants