Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QROT and MS gate #193

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Add QROT and MS gate #193

merged 4 commits into from
Feb 22, 2023

Conversation

BoxiLi
Copy link
Member

@BoxiLi BoxiLi commented Feb 18, 2023

Add the QROT gate class.

@BoxiLi
Copy link
Member Author

BoxiLi commented Feb 18, 2023

Hi @ajrazander Would you like to have a review?

Does this definition of single-qubit rotation make sense? Or is there a better name than QROT?

@ajrazander
Copy link
Contributor

The gate looks good! The QROT name could be improved. In the literature it's usually referred to as just R. I kind of like that as it fits with the naming scheme that already exists for the Rx, Ry, and Rz gates. Using R would also put it in the list of gates near the Rx, Ry, Rz gates which would make searching for it easier and more recognizable for new users.

@BoxiLi BoxiLi merged commit fd84732 into qutip:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants