Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install qutip-qtrl master version for the tests #198

Merged
merged 2 commits into from
Apr 16, 2023
Merged

Install qutip-qtrl master version for the tests #198

merged 2 commits into from
Apr 16, 2023

Conversation

BoxiLi
Copy link
Member

@BoxiLi BoxiLi commented Apr 16, 2023

  • Test against the qutip alpha release.
  • Install qutip-qtrl from master

hodgestar
hodgestar requested changes Apr 16, 2023
View reviewed changes
Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would perhaps be nice to keep the qutip-4.7.X build to be sure we don't break qutip-qip on the qutip-4.7.X branch before a release.

I think installing qutip-qtrl from master when testing qutip master makes sense.

@BoxiLi
Copy link
Member Author

BoxiLi commented Apr 16, 2023

Thanks Simon! Yes, I can add the 4.7.X check back. I was thinking that not many changes happen now on 4.7.X.

@BoxiLi BoxiLi merged commit cf8cd75 into qutip:master Apr 16, 2023
12 checks passed
@BoxiLi BoxiLi deleted the qutip-qtrl branch April 17, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodgestar hodgestar hodgestar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BoxiLi @hodgestar