Update the parsing mode for read_qasm #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the ambiguous mode "qiskit" and add "default", "predefine_only" and "external_only"
We don't attach this files in the the test folders. All the gates used are implemented by default. Before, they are ignore because the default mode uses only predefined gates in qutip-qip. Since the "default" mode now also take external gates if provided, an error will be raised if this file does not exist.
This whole function are already skipped if the mode is external_only
BoxiLi
added a commit
to BoxiLi/qutip-qip
that referenced
this pull request
Apr 20, 2024
Update the parsing mode for read_qasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the ambiguous mode "qiskit" and add "default", "predefine_only" and "external_only".
Fix #208