Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes gate label import #63

Closed
wants to merge 3 commits into from
Closed

Fixes gate label import #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28a9ecc
gate imports
purva-thakre Jun 21, 2021
e8332df
syntax
purva-thakre Jun 21, 2021
085e3fa
j
purva-thakre Jun 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/qutip_qip/circuit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@
csign, berkeley, swapalpha, swap,
iswap, sqrtswap, sqrtiswap, fredkin,
toffoli, controlled_gate, globalphase,
expand_operator, gate_sequence_product)
expand_operator, gate_sequence_product,
_GATE_NAME_TO_LABEL,_gate_label)

from qutip import tensor, basis, identity, ket2dm, qeye
from qutip.qobj import Qobj
from qutip.measurement import measurement_statistics
Expand Down
2 changes: 1 addition & 1 deletion src/qutip_qip/operations/gates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
'gate_expand_1toN', 'gate_expand_2toN', 'gate_expand_3toN',
'qubit_clifford_group', 'expand_operator', '_single_qubit_gates',
'_para_gates', '_ctrl_gates','_swap_like','_toffoli_like',
'_fredkin_like']
'_fredkin_like','_GATE_NAME_TO_LABEL','_gate_label']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't add these _ constants and functions to __all__ I don't think and we don't need to import _GATE_NAME_TO_LABEL in circuit.py at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to import _GATE_NAME_TO_LABEL in circuit.py at all

We do actually. It's used in circuit.py. I tried running one of the notebooks with _gate_label and that caused some errors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ ag _GATE_NAME_TO_LABEL .
src/qutip_qip/operations/gates.py
171:            if (name in _GATE_NAME_TO_LABEL) and (arg_value is not None):
226:_GATE_NAME_TO_LABEL = {
263:    if name in _GATE_NAME_TO_LABEL:
264:        gate_label = _GATE_NAME_TO_LABEL[name]

I'm not seeing it used anywhere other than in gates.py? Could you provide a link to where else it is used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was confused between _gate_label and _GATE_NAME_TO_LABEL. You are right. Only _gate_label has to be imported.

Although, for this issue Boxi wanted a separate PR. Feel free to close this PR if that's changed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I was asking for a separate PR mainly because the decomposition is a new feature and this is a bug fix. Mixing them might cause some confusion if someone checks the history one day. As #66 is all about bug fixing and cleaning, I can just merge that one and saves you the trouble of updating it for _GATE_NAME_TO_LABEL. But thank you anyway!



_single_qubit_gates = ["RX", "RY", "RZ", "SNOT", "SQRTNOT", "PHASEGATE",
Expand Down