Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use qutip_qtrl.logging_utils instead of qutip.logging_utils #10

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

BoxiLi
Copy link
Member

@BoxiLi BoxiLi commented Apr 10, 2023

Some part of qutip_qtrl is still using the qutip.logging_util. Remove them.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4659203432

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 4598329331: 0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 10, 2023

Pull Request Test Coverage Report for Build 4659203432

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on logging_util at 68.994%

Totals Coverage Status
Change from base Build 4598329331: 69.0%
Covered Lines: 3271
Relevant Lines: 4741

💛 - Coveralls

@hodgestar hodgestar merged commit 212b401 into qutip:master Apr 10, 2023
21 checks passed
@hodgestar
Copy link
Contributor

Thanks, @BoxiLi.

@BoxiLi
Copy link
Member Author

BoxiLi commented Feb 12, 2024

Is there a plan to make a new release at some point to include this? Otherwise qutip==5.0.0a2 does not have a working control package.

@hodgestar
Copy link
Contributor

@BoxiLi v0.1.1 released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants