Implement and test process fidelity #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericgig
requested changes
Nov 16, 2021
There was a problem hiding this comment.
Looks good.
It's great to have a proper documentation, tests, and a properly defined function.
_process_fidelity_to_id makes it easier to read.
Since the definition of the function changed, could you add a warning. We need to be clear that when going from v4 to v5, the result will change and we can't expect everybody will read the documentation.
- Refactor tests of process_fidelity using pytest.mark.parametrize - In one branch of process_fidelity, divide fidelity by dimensional factor instead of dividing density matrices
Ericgig
approved these changes
Nov 25, 2021
hodgestar
reviewed
Nov 25, 2021
Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
|
@fhopfmueller Thank you for making this PR happen! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements and tests a new version of
process_fidelity.The new version follows the definition in Gilchrist et al., Physical Review A 71, 062310 (2005).
Related issues or PRs
Discussion at #1703.
I previously submitted a similar PR at #1708, targeting
master.This PR targets
dev.majorrather thanmasterbecause existing functionality is changed, and contains improvements following @Ericgig 's suggestions. I have also adapted the tests to match the style of the tests indev.major.Addresses part 2 of #1703.
Changelog
Implement and test a new version of
process_fidelity(#1703)