Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce qutip import time by setting logger names (v5) #1981

Merged
merged 2 commits into from Aug 19, 2022
Merged

Reduce qutip import time by setting logger names (v5) #1981

merged 2 commits into from Aug 19, 2022

Conversation

eendebakpt
Copy link
Contributor

Description

This PR reduced the qutip import time by setting the logger names explicitly.

Related issues or PRs

See #1980 for more details.

@coveralls
Copy link

coveralls commented Aug 18, 2022 •
edited

Coverage Status

Coverage increased (+0.002%) to 71.555% when pulling b6d2bbf on eendebakpt:importtimes_logging into f49ef7a on qutip:dev.major.

hodgestar
hodgestar approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hodgestar hodgestar added this to the QuTiP 5.0 milestone Aug 19, 2022
@hodgestar hodgestar merged commit 860c4f0 into qutip:dev.major Aug 19, 2022
@hodgestar hodgestar changed the title Draft: Reduce qutip import time by setting logger names Reduce qutip import time by setting logger names Aug 19, 2022
@hodgestar hodgestar changed the title Reduce qutip import time by setting logger names Reduce qutip import time by setting logger names (v5) Aug 19, 2022
@eendebakpt eendebakpt deleted the importtimes_logging branch August 19, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodgestar hodgestar hodgestar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
QuTiP 5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eendebakpt @coveralls @hodgestar