-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dimensions class #1996
Merged
Merged
Dimensions class #1996
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
bb9ecde
Add Dimensions class to Qobj
Ericgig ea92672
Merge branch 'dev.major' of https://github.com/qutip/qutip into dims.…
Ericgig d70bc88
Merge branch 'dev.major' of https://github.com/qutip/qutip into dims.…
Ericgig 027e65b
simpler qobj init
Ericgig a220e78
Fix doc build
Ericgig 07a0244
Add docstrings
Ericgig 5ef0152
type as property
Ericgig 98a9c17
Merge remote-tracking branch 'upstream/master' into dims.rework
a975637
Add __all__ to dimensions.py
Ericgig 87d9592
Merge branch 'master' of https://github.com/qutip/qutip into dims.rework
Ericgig c2ecbb3
Merge branch 'master' of https://github.com/qutip/qutip into dims.rework
Ericgig 697d246
Add towncrier entry
Ericgig c8d5b97
Merge branch 'master' of https://github.com/qutip/qutip into dims.rework
Ericgig 92ce62e
Merge branch 'master' of https://github.com/qutip/qutip into dims.rework
Ericgig f0f8e9a
Fix comments
Ericgig 2f3974c
Apply suggestions from code review
Ericgig 38800d8
improve code climate
009e605
Apply suggestions from code review
Ericgig 9c72295
Improve from comments
Ericgig 79e2d8d
Merge branch 'dims.rework' of https://github.com/Ericgig/qutip into d…
Ericgig d039094
Merge branch 'master' of https://github.com/qutip/qutip into dims.rework
Ericgig 05037cc
Remove old type check functions
Ericgig a93c7d5
start removing Qobj(type)
Ericgig 5c73919
start removing Qobj(type)
Ericgig 7aa4bf0
Remove type setting
Ericgig 3fb1322
Rm type and reshape in Qobj.__init__
80c6aad
Stricker list format test
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Create a Dimension class |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also have a means for the user to access the actual dims object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To discuss, I do not like the list format much and would be fine with keeping it only for input and print.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also be happy to only use the list format for input and printing the dims, but it would break some existing usage patterns (e.g.
.dims[0]
). This is v5 though, so maybe that is okay. Perhaps something we can discuss in the admin meeting or on the mailing list?