add arguments for plot_wigner_fock_distribution #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KosukeMizuno
force-pushed
the
plot_wigner_args
branch
from
119cc52
to
8f1094e
Compare
Ericgig
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Sorry @KosukeMizuno for letting this fall though the cracks.
The change looks good, thank you for the contribution.
|
Since this PR was made, a new function, |
|
oh you were much faster than me. Anyway thanks for approving this change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #1112. The scalling of Winger fuction can be changed in
wigner()(default isg=sqrt(2)). But it cannot be specified withplot_wigner()orplot_wigner_fock_distribution(). For my usage, it should beg=2, so it was inconvenient. I modified these two plotter functions to passg(and the other args ofwigner()).