Better operator dimension parameterisation #2075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericgig
reviewed
Feb 7, 2023
Comment on lines
+632
to
+634
| dimensions : int (default: 2) / list of ints | ||
| Number of Fock states in Hilbert space. If a list, then the resultant | ||
| object will be a tensor product over spaces with those dimensions. |
There was a problem hiding this comment.
This is now wrong when an integer is passed: that number will not be the total number of Fock states, but the size of each spaces, one for each element in seq. Let's leave the doc string as is for now. ket and bra are don't follow normal convention anyway.
| @@ -1279,7 +1281,7 @@ def w_state(N=3, *, dtype=_data.Dense): | |||
| Parameters | |||
| ---------- | |||
| N : int (default=3) | |||
| Number of qubits in state | |||
| Number of Fock states in Hilbert space. | |||
There was a problem hiding this comment.
Here N is a number of qubit, not the size of a space...
The variable name could be changed to avoid confusion.
| A list of the dimensions of each subsystem of a composite quantum | ||
| system. | ||
| dims : list or array | ||
| The quantum state dimensions array, as it would appear in a Qobj. |
There was a problem hiding this comment.
All enr_... functions take the same dims input. It's doc-string should match between the enr_operators and enr_states.
|
Thank you again @PriyanshuPansari, but this is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the inconsistency in the dimension argument of Qutip operators in the naming, type, and description.
Proposed generalization - use N to denote the dimension of Hilbert space if it's int or denote a list with the number of states in each sub-system if it's a list.
fixes #1722
Used the following conventions-
in States.py-
dimensions : int or list of ints
Number of Fock states in Hilbert space. If a list, then the resultant
object will be a tensor product over spaces with those dimensions.
N: int
Number of Fock states in Hilbert space.
dims : list or array
The quantum state dimensions array, as it would appear in a Qobj.
dim: list
A list with the number of states in each sub-system.
in Opearator.py-
dimensions : (int) or (list of int) or (list of list of int)
Dimension of Hilbert space. If provided as a list of ints, then the
dimension is the product over this list, but the
dimsproperty ofthe new Qobj are set to this list. This can produce either
operorsuperdepending on the passeddimensions.N: int
Number of Fock states in Hilbert space.