Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #1998. #2082

Merged
merged 2 commits into from Feb 10, 2023
Merged

Fixed issue #1998. #2082

merged 2 commits into from Feb 10, 2023

Conversation

AGaliciaMartinez
Copy link
Member

@AGaliciaMartinez AGaliciaMartinez commented Feb 9, 2023 •
edited

This was solved in dev.major #1865. Thanks Eric for pointing out the solution :).

Related issues or PRs
fix #1998

@AGaliciaMartinez
Fixed issue qutip#1998.
8ee1be2 
This was solved in dev.major qutip#1866. Thanks Eric for pointing out the
solution :).
@AGaliciaMartinez
Added changelog.
6914a01
Ericgig
Ericgig approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@Ericgig Ericgig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for the fix.
Failing tests are unreleated.

Please do not close #1998 as the sparse eigensolver issue is still there.

@AGaliciaMartinez AGaliciaMartinez merged commit dbed07c into qutip:qutip-4.7.X Feb 10, 2023
@AGaliciaMartinez AGaliciaMartinez deleted the fix_1998 branch February 10, 2023 09:11
@hodgestar hodgestar added this to the QuTiP 4.7.2 milestone Feb 27, 2023
@hodgestar hodgestar mentioned this pull request Feb 27, 2023
Open
@Ericgig Ericgig mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericgig Ericgig Ericgig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
QuTiP 4.7.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AGaliciaMartinez @Ericgig @hodgestar