New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move html progressbar #2112
Move html progressbar #2112
Conversation
@Ericgig Please review the PR.Thanks! |
@AGaliciaMartinez Can you please review this PR and get it merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself looks good. I left one small suggestion. I've also activated the test runs, so we should see if those pass.
It would be good to add tests for the progress bars, but perhaps that is best done in a follow up PR. For example, I know that the TqdmProgressBar currently does not work.
@hodgestar PTAL! Thanks |
Thanks @HarshKhilawala! |
@HarshKhilawala Would you be interested in adding some tests for the progress bars in another PR? |
@hodgestar Sure, do I need to be assigned another issue? Can I create new issue for writing tests for progress bar and get assigned to work on it? |
No need for a new issue. You can just open a PR. No harm in having an issue
too though.
|
@hodgestar I am not much aware with writing tests. Can you help me write test for progressbar file? How to write a test? How to check coverage for the entire file? How to check coverage for each line of code as to know where and what to add test? From where can I learn more about testing? Any documentation for writing tests specifically for qutip repository? |
@hodgestar Anything for reference? Any pre-existing test_code which I can use to write tests for progressbar? PTAL! |
@Ericgig Can you help me with this one? I am considering adding tests for progressbar. |
There are no test code for progress bars yet. The test can be as simple as creating the bar, call |
Checklist
Thank you for contributing to QuTiP! Please make sure you have finished the following tasks before opening the PR.
You can use pycodestyle to check your code automatically
doc
folder, and the notebook. Feel free to ask if you are not sure.doc/changes/<PR number>.<type>
'type' can be one of the following: feature, bugfix, doc, removal, misc, or deprecation (see here for more information).Delete this checklist after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work and keep this checklist in the PR description.
Description
Moved HTMLProgressBar from
qutip/ipynbtools.py
toqutip/ui/progressbar.py
Related issues or PRs
Fix #2108