Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qutip.control and replace with qutip_qtrl. #2116

Merged
merged 5 commits into from Mar 13, 2023

Conversation

hodgestar
Copy link
Contributor

Description
Remove qutip.control and replace it with the QuTiP family package qutip-qtrl.

Related issues or PRs

  • None

@hodgestar hodgestar added this to the QuTiP 5.0 milestone Mar 13, 2023
@hodgestar hodgestar requested a review from Ericgig March 13, 2023 13:42
@coveralls
Copy link

coveralls commented Mar 13, 2023

Coverage Status

Coverage: 75.43% (+3.08%) from 72.353% when pulling 92edcd4 on feature/replace-qutip-control-with-qutip-qtrl into ae6d693 on master.

Copy link
Member

@Ericgig Ericgig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see this moved out.
But qutip-qip and some tutorial use it.
So we should wait for qutip-ctrl to be added to their requirement before merging.

@hodgestar
Copy link
Contributor Author

But qutip-qip and some tutorial use it. So we should wait for qutip-qctrl to be added to their requirement before merging.

Good point. I will talk to @BoxiLi.

@hodgestar
Copy link
Contributor Author

hodgestar commented Mar 13, 2023

The tutorials only use it indirectly, so it's just qutip-qip that we need to update.

Update: This might be a little tricky, since qutip-qtrl only supports QuTiP v5 and qutip-qip supports both v4 and v5.

@Ericgig
Copy link
Member

Ericgig commented Mar 13, 2023

Some of the example notebook on the web page call it directly: https://nbviewer.org/github/qutip/qutip-notebooks/blob/master/examples/control-pulseoptim-QFT.ipynb
It seems they are still in qutip-notebook.

@hodgestar
Copy link
Contributor Author

Some of the example notebook on the web page call it directly: https://nbviewer.org/github/qutip/qutip-notebooks/blob/master/examples/control-pulseoptim-QFT.ipynb It seems they are still in qutip-notebook.

The qutip-notebooks are only for QuTiP v4, but yes, we do have to migrate those to qutip-tutorials and make them v5 compatible.

@hodgestar hodgestar merged commit 0e9f052 into master Mar 13, 2023
22 checks passed
@hodgestar hodgestar deleted the feature/replace-qutip-control-with-qutip-qtrl branch April 3, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants