New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize dispatcher by using positional only arguments #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hodgestar
requested changes
Apr 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some small suggestions, but overall this is a great simplification.
Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
hodgestar
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I optimized the dispatched by only supporting positional arguments for matrix to dispatch on:
The dispatcher was supporting any signature for dispatched functions.
Since each dispatchers is an instance of the
Dispatcher
class and cython does not support patching methods, it had to find the inputs matrix to convert from__call__(*args, **kwargs)
and re-implemented the_bind
method to do so.But all our dispatched functions have the matrix as the first positional argument, by embracing this we get a nice speed up for small matrices.
Also when the specialization existed, it would not call it directly, but call a
_constructed_specialisation
that called ti. Adding another unneeded layer to each calls. This was changed so it would call the function directly.For a 2x2 matrix:
Sadly it will not improve the benchmarks that much since the
Qobj
operations overhead is quite large: