New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added info about sec_cutoff to the documentation #2136
Conversation
Could you fix the git diff issue. We can't see your changes like this. |
Hi Eric, I would love to but I simply don't know what the git diff issue is, might it be that only the file that I modified should show in the diff? |
Yes, only the files you modified should appear in the diff, right now it seems like your PR changed 256 files, but the files seems to have the same content... If we can't easily see what changed, we can't review the PR. |
Thanks for clearing that, I'm also not sure how that happened, but it should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution.
The example should be in a code block.
Could you fix format (2 spaces between words, missing capitalization, ...).
Thanks for your feedback, I think it should be better now |
@nwlambert could you confirm that the addition is exact? |
seems ok, perhaps just referencing how sec_cutoff relates to the condition mentioned above equation 4 in the documentation would make it more precise? |
Hi, I added the reference to the equation. I wanted to be more specific but couldn't figure out from the code if the cutoff is something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just fix the spacing in the code and it will be ready to merge.
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
Sorry for taking this long to reply, I was on holiday. Should be ready now, thanks ! |
Description
I added a note at the end of the time independent Bloch-Redfield equation section, to indicate that one can simulate the nonsecular version using the sec_cutoff keyword