Update ttmsolve for v5
#2142
Merged
Update ttmsolve for v5
#2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example in qutip/qutip-tutorials#63 |
hodgestar
requested changes
Mar 31, 2023
Co-authored-by: Simon Cross <hodgestar+github@gmail.com>
hodgestar
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move
ttmsolvetoqutip/solverand update it.No class interface was created,
ttmsolvework differently to other solver and would be hard to force into theSolvermould.Changed the interface a little,
learningtimesneeded use the first valuestimesto be valid, it was replaced by an options for the number of values intimesto use.