Add a test for progress bar #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hodgestar
requested changes
Apr 11, 2023
There was a problem hiding this comment.
Thanks for sorting this out.
All the calls to construct progress bar should move to where .start() was originally. I would also prefer if the tests where a bit more explicit about what they were testing. Having tests decide what to test based on the code is a bad idea, because the code can easily be wrong (e.g. we might forget to add something to the list of progress bars) and it's good to have a pattern of "if the code is changed, the tests should change too".
qutip/tests/test_progressbar.py
Outdated
| bar = progress_bars[pbar](N) | ||
| except ImportError: | ||
| # ipython or tqdm could be missing | ||
| pytest.skip(reason="module not available") |
There was a problem hiding this comment.
We should probably list the progress bars explicitly and mark which ones to skip. Otherwise this will skip tests if something fails to import and it might take a long time to realize.
hodgestar
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
startprivate.startwas mostly used right after the initialization. The docstring indicated that it was not needed, but it was for most bars. EnhancedTextProgressBar not coherent with docstring of BaseProgressBar #2148HTMLProgressBarimport ipython.Related issues or PRs
Fix the issue #2148 for master.
Replace #2127