Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix_histogram_complex() colorbar pad to 0.05 #2181

Merged
merged 2 commits into from Jun 30, 2023
Merged

Conversation

SJUW
Copy link
Contributor

@SJUW SJUW commented Jun 26, 2023

Description
Increase missing colorbar padding for matrix_histogram_complex() from 0 to 0.05.

Increase missing colorbar padding for matrix_histogram_complex() from 0 to 0.05.
@SJUW SJUW closed this Jun 26, 2023
@SJUW SJUW reopened this Jun 26, 2023
@Ericgig
Copy link
Member

Ericgig commented Jun 27, 2023

Thank you @SJUW for the PR.
We have a GSoC reworking our visualization functions this summer.
@tamakoshi2001 would you be up to review this?

@coveralls
Copy link

coveralls commented Jun 27, 2023

Coverage Status

coverage: 78.106% (-0.02%) from 78.129% when pulling e07d26c on SJUW:patch-1 into ec0fcc6 on qutip:master.

@tamakoshi2001
Copy link
Contributor

@Ericgig Sure!

@tamakoshi2001
Copy link
Contributor

@SJUW Hi. Can you show me a plot? I want to see that your change is better.

@SJUW
Copy link
Contributor Author

SJUW commented Jun 27, 2023 via email

@SJUW
Copy link
Contributor Author

SJUW commented Jun 28, 2023

image

@tamakoshi2001
Copy link
Contributor

@SJUW Thank you! It looks better.
Yes. We plan to merge matrix_histogram and matrix_histogram_complex.

Can you add a towncrier? The way is here;
https://qutip.org/docs/latest/development/contributing.html

@Ericgig Ericgig mentioned this pull request Jun 28, 2023
@tamakoshi2001
Copy link
Contributor

@SJUW Thanks!

@tamakoshi2001
Copy link
Contributor

@Ericgig Hi. His work is fine for me.

@Ericgig Ericgig merged commit f66b8f2 into qutip:master Jun 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants