Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cython version to pre 3.0.0 #2204

Merged
merged 2 commits into from Jul 24, 2023
Merged

Fix cython version to pre 3.0.0 #2204

merged 2 commits into from Jul 24, 2023

Conversation

Ericgig
Copy link
Member

@Ericgig Ericgig commented Jul 24, 2023

Description
Couldn't make #2202 work...
There are segfault in brmesolve with cython 3.0.0 and the new compilation method does not work properly on windows.
This replace the PR with a simple limitation to not use cython 3.0.0.

@coveralls
Copy link

coveralls commented Jul 24, 2023 •
edited

Coverage Status

coverage: 70.175% (+0.2%) from 69.989% when pulling 10bdfa9 on Ericgig:misc.cy3_for_4.7.v2 into e010ce4 on qutip:qutip-4.7.X.

hodgestar
hodgestar approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was worth a shot making Cython 3.0 work, but perhaps better to leaving fixing it for another time when either we have a better idea or Cython 3 has matured a bit.

@Ericgig Ericgig merged commit a2a289e into qutip:qutip-4.7.X Jul 24, 2023
12 checks passed
@Ericgig Ericgig deleted the misc.cy3_for_4.7.v2 branch July 24, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodgestar hodgestar hodgestar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericgig @coveralls @hodgestar