Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import with cython 3 #2207

Merged
merged 5 commits into from Jul 31, 2023
Merged

Fix import with cython 3 #2207

merged 5 commits into from Jul 31, 2023

Conversation

Ericgig
Copy link
Member

@Ericgig Ericgig commented Jul 26, 2023 •
edited

Description
When cython 3 is installed, qutip will run in no cython mode and a warnings will be raised.

I also removed the rhs_generate function. It was only used in an example in the documentation which no longer do what it says.

(See #2202 for my tries in making home made runtime compilation works with cython 3.)

@coveralls
Copy link

coveralls commented Jul 26, 2023 •
edited

Coverage Status

coverage: 70.42% (+0.2%) from 70.175% when pulling e53e5e1 on Ericgig:misc.cy_warnings into a2a289e on qutip:qutip-4.7.X.

@Ericgig Ericgig changed the title Qutip can be imported with cython 3 Fix import with cython 3 Jul 28, 2023
@Ericgig Ericgig requested a review from hodgestar July 28, 2023 13:56
hodgestar
hodgestar approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Is rhs_clear used for anything with rhs_generate gone?

@Ericgig
Copy link
Member Author

Ericgig commented Jul 31, 2023

rhs_clear is still used to reset solver stored with rhs_reuse.

@Ericgig Ericgig merged commit c2d7eaa into qutip:qutip-4.7.X Jul 31, 2023
12 checks passed
@Ericgig Ericgig deleted the misc.cy_warnings branch July 31, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodgestar hodgestar hodgestar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericgig @coveralls @hodgestar