Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate orbital #2223

Merged
merged 6 commits into from Sep 1, 2023
Merged

Deprecate orbital #2223

merged 6 commits into from Sep 1, 2023

Conversation

Ericgig
Copy link
Member

@Ericgig Ericgig commented Aug 31, 2023

Description
Remove orbital.
It is still used in tutorials.

@@ -60,6 +59,13 @@
from .about import *
from .cite import *


def orbital(*_, **__):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy for us to just drop orbital. We can add this note to the release notes instead.

Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've prefer to drop the not implemented orbital function and just replace it with a note in the release notes, but otherwise looks good.

@coveralls
Copy link

coveralls commented Aug 31, 2023

Coverage Status

coverage: 84.939% (+0.008%) from 84.931% when pulling afebd72 on Ericgig:rm.orbital into 2dc5f3f on qutip:master.

qutip/__init__.py Outdated Show resolved Hide resolved
@Ericgig Ericgig merged commit 8df0937 into qutip:master Sep 1, 2023
12 checks passed
@Ericgig Ericgig deleted the rm.orbital branch September 1, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants