Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster kraus_to_choi in qutip 5 #2284

Merged
merged 6 commits into from Jan 11, 2024
Merged

Faster kraus_to_choi in qutip 5 #2284

merged 6 commits into from Jan 11, 2024

Conversation

theodotk
Copy link
Contributor

@theodotk theodotk commented Jan 5, 2024

Description
Adaptation of PR #2283 to qutip 5: using np.tensordot instead of a triple loop.

Co-authored with Rafael Haenel

@theodotk theodotk changed the title Faster kraus_to_choi Faster kraus_to_choi in qutip 5 Jan 5, 2024
@theodotk
Copy link
Contributor Author

theodotk commented Jan 5, 2024

It seems that failing tests are not related to this change

Copy link
Member

@Ericgig Ericgig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@theodotk
Copy link
Contributor Author

theodotk commented Jan 9, 2024

I see that there were PRs with ignoring the deprecation warnings.
Do i need to make another push to make the tests restart in this PR?

@Ericgig
Copy link
Member

Ericgig commented Jan 9, 2024

No, it's all good.
Just waiting to see if others also want to take a look before merging.

@Ericgig Ericgig merged commit e785309 into qutip:master Jan 11, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants